fix(bonding_manager): fix validation of epoch when bonding/unbonding #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v2_contracts #371 +/- ##
========================================================
+ Coverage 90.90% 90.92% +0.02%
========================================================
Files 280 280
Lines 31830 31917 +87
========================================================
+ Hits 28936 29022 +86
- Misses 2894 2895 +1 ☔ View full report in Codecov by Sentry. |
kerber0x
requested review from
0xFable,
kaimen-sano,
Sen-Com and
nseguias
as code owners
|
Schema generation had missing jobs: Please run |
|
Schema generation had missing jobs: Please run |
kerber0x
force-pushed
the
fix/epoch-validation-on-bond
branch
from
6577a07 to
8670d58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
This PR improves the validation when bonding/unbonding so it makes sure not only that a new epoch has been created but that the system is up to date, i.e. if an epoch is due to be created the contract won't let you bond or unbond.
Related Issues
Checklist:
Update index.md)cargo fmt --all --.cargo clippy -- -D warnings.cargo schema.